Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Debian 12 #357

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Support Debian 12 #357

merged 2 commits into from
Oct 29, 2023

Conversation

traylenator
Copy link
Contributor

@traylenator traylenator commented Jun 27, 2023

Pull Request (PR) description

In particular with Debian 11->12 systemd-resolved is now a sub package
that must be installed.

Clearly there are no tests running for Debian 12 yet.

@traylenator
Copy link
Contributor Author

Needs a bit more testing as enabling with:

class{'systemd':
  manage_resolved   => true,
  use_stub_resolver => true,
}

I lost DNS. ( fixed by reboot and now running and using systemd-resolved )

@traylenator traylenator added the enhancement New feature or request label Jun 27, 2023
@traylenator
Copy link
Contributor Author

Needs a bit more testing as enabling with:

class{'systemd':
  manage_resolved   => true,
  use_stub_resolver => true,
}

I lost DNS. ( fixed by reboot and now running and using systemd-resolved )

Understood - not relevent.

@traylenator traylenator marked this pull request as ready for review June 27, 2023 20:34
@kenyon kenyon mentioned this pull request Jul 3, 2023
@saz
Copy link
Sponsor Contributor

saz commented Aug 7, 2023

LGTM.

We should think about, installing systemd-resolved and systemd-timesyncd by default and just disable it on Debian 10(?) and 11, if required. Currently, any newer Debian release might "break", as the packages are missing, no configuration is happening, but at the same time, there won't be any error message.

Copy link

@anarcat anarcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@traylenator
Copy link
Contributor Author

@tuxmea Did you try migrating with this - I do loose initially which I never really understood?

@ekohl
Copy link
Member

ekohl commented Oct 13, 2023

FYI: voxpupuli/puppet_metadata#102 would add Debian 12 to acceptance tests using distro packages so you at least have Puppet 7 to test with.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we apply this with voxpupuli/modulesync_config#855 we should have at least some acceptance test.

In particular with Debian 11->12 systemd-resolved is now a sub package
that must be installed.
@ekohl
Copy link
Member

ekohl commented Oct 29, 2023

I took the liberty of rebasing this.

Comment on lines 15 to 19
# RedHat 7, 9, Debian 12 and newer installs package first run before fact $facts['internal_services'] is set
if (fact('os.release.major') != '8' && (fact('os.family') == 'RedHat')) ||
((fact('os.name') == 'Debian' && fact('os.release.major').to_i >= 12))
apply_manifest(pp, catch_failures: true)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For systemd-networkd I extracted this to a separate variable:

has_package = fact('os.family') == 'RedHat'

Then I reused it to check if the package is installed:

it { expect(package('systemd-networkd')).to be_installed } if has_package

@bastelfreak bastelfreak merged commit 6083dd4 into voxpupuli:master Oct 29, 2023
34 checks passed
@ekohl ekohl linked an issue Nov 22, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Debian 12 support
6 participants